Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclude_snapshots query param to export/sqlite #367

Merged
merged 1 commit into from
May 29, 2020
Merged

Add exclude_snapshots query param to export/sqlite #367

merged 1 commit into from
May 29, 2020

Conversation

zhouzhuojie
Copy link
Collaborator

Description

Sometimes the snapshots table is just too big to download, wanted to introduce a query param that can help to reduce the sqlite export size. This is fully backward compatible.

Motivation and Context

How Has This Been Tested?

unit tests and integration test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhouzhuojie zhouzhuojie requested review from buzzyapyear and a team May 29, 2020 00:47
@codecov-commenter
Copy link

Codecov Report

Merging #367 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   81.37%   81.38%   +0.01%     
==========================================
  Files          27       27              
  Lines        1605     1606       +1     
==========================================
+ Hits         1306     1307       +1     
  Misses        222      222              
  Partials       77       77
Impacted Files Coverage Δ
pkg/handler/export.go 69.64% <66.66%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9bca69...56205c8. Read the comment docs.

buzzyapyear
buzzyapyear approved these changes May 29, 2020
View reviewed changes
Copy link

@buzzyapyear buzzyapyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense to have the option.

@zhouzhuojie zhouzhuojie merged commit eddc50d into master May 29, 2020
@zhouzhuojie zhouzhuojie deleted the zz/add-exclude-snapshots-to-export-sqlite branch May 29, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buzzyapyear buzzyapyear buzzyapyear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhouzhuojie @codecov-commenter @buzzyapyear